Skip to content

Expose hydrateRoot options. #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Expose hydrateRoot options. #527

merged 1 commit into from
Jun 18, 2025

Conversation

peterp
Copy link
Member

@peterp peterp commented Jun 17, 2025

This exposes hydrationOptions from hydrateRoot. This is required to turn off errors that occur when HTML rendering is disable.

import { initClient } from 'rwsdk/client'

initClient({ hydrationOtions: {...} })

cc: @jldec

@peterp
Copy link
Member Author

peterp commented Jun 17, 2025

Based off of this PR: jldec/agents-chat#25

@peterp peterp requested a review from justinvdm June 17, 2025 20:30
@peterp
Copy link
Member Author

peterp commented Jun 17, 2025

@justinvdm Open to a discussion about this, I don't know if there's a better way.

@justinvdm
Copy link
Collaborator

@peterp sorry for the delay, just wrapping my head around this all now

@justinvdm
Copy link
Collaborator

@peterp is the idea that we'd catch the error?

If so, I don't think it'd hurt to expose they hydrateRoot options, so will merge, but I also feel like we should be able to avoid hydration mismatches in the first place for this "empty shell" case. I'll investigate.

@justinvdm justinvdm merged commit 94b3c40 into main Jun 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants